test: avoid initial-break sync in attach-only debugger tests#61937
Draft
inoway46 wants to merge 1 commit intonodejs:mainfrom
Draft
test: avoid initial-break sync in attach-only debugger tests#61937inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
497d1a4 to
67c068f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForInitialBreak()with attach/prompt synchronization in:test/parallel/test-debugger-watch-validation.jstest/parallel/test-debugger-extract-function-name.mjstest/parallel/test-debugger-random-port-with-inspect-port.jsbreak ... inoutput, sync onDebugger attached.(+waitForPrompt()where needed)test/common/debugger.jsbehavior unchanged (test-side synchronization only)Context
test-macOSunusual-path failures have shown intermittent timeouts inwaitForInitialBreak()for attach-only debugger tests.In failing logs, attach and prompt can appear, but the initial break banner wait becomes a fragile sync point.
test/parallel/test-debugger-watch-validation.jstest/parallel/test-debugger-extract-function-name.mjstest/parallel/test-debugger-random-port-with-inspect-port.jsHypothesis
The flake is likely a timing race in startup output ordering:
waitForInitialBreak()depends on observing the initialbreak ... inbannerThis change narrows synchronization only in the three target tests and does not claim a single root cause in debugger internals.
Why this approach
Testing
./tools/test.py -p actions parallel/test-debugger-watch-validation(passes locally)./tools/test.py -p actions parallel/test-debugger-random-port-with-inspect-port(passes locally)./tools/test.py -p actions parallel/test-debugger-extract-function-name(passes locally)./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-watch-validation parallel/test-debugger-random-port-with-inspect-port parallel/test-debugger-extract-function-name./tools/test.py -p actions -j4 --repeat 100 parallel/test-debugger-watch-validation parallel/test-debugger-random-port-with-inspect-port parallel/test-debugger-extract-function-nameRefs: #61762